My first Pull Request

By Yihang Ho

My first legitimate pull request was (finally) accepted, it is right over here.

For people who are not familiar with the term, a pull request is essentially a request for your contribution to be accepted into someone else's code base.

I used the word "legitimate" as I have actually submitted (and all of them were accepted blush) several other pull requests, none of them touched the actual code. Their effects range from fixing typo to bumping up the version of a dependency to requesting my plugin to be included to the official site.

It took exactly a week for my pull request to be accepted, not because the owners are lazy, but the exact opposite. @parkr, who helps maintaining the Jekyll project helped improve my contribution from lousy to suck less to much better. As a result, I can say that at least 50% of this contribution is his!

Nonetheless, I am proud to say that I am finally contributing to an open source project. At least a few lines of code written by me will be executed whenever someone run jekyll build, and this is awesome. grin